[chore][exporter/clickhouse] Fix broken makefile command for examples #30161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Dec 21, 2023
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…open-telemetry#30161) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The ClickHouse exporter contains a docker example with `telemetrygen` generating traces to send to the otel collector, which then sends to the ClickHouse backend. Grafana is then used to view traces. The make commands were broken due being in the wrong directory when executing, as well as the deprecation of `tracegen` in favor of `telemetrygen traces`. **Link to tracking Issue:** <Issue number if applicable> Resolves open-telemetry#30159 **Testing:** <Describe what testing was performed and which tests were added.> Both `make` commands are working and everything's up and running. Also confirmed `telemetrygen` is properly sending traces to the collector. Note: I'm not familiar enough with Grafana or ClickHouse to be able to validate clickhouse exporter functionality in the example. A code owner or user will have to verify the example still works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The ClickHouse exporter contains a docker example with
telemetrygengenerating traces to send to the otel collector, which then sends to the ClickHouse backend. Grafana is then used to view traces. The make commands were broken due being in the wrong directory when executing, as well as the deprecation oftracegenin favor oftelemetrygen traces.Link to tracking Issue:
Resolves #30159
Testing:
Both
makecommands are working and everything's up and running. Also confirmedtelemetrygenis properly sending traces to the collector.Note: I'm not familiar enough with Grafana or ClickHouse to be able to validate clickhouse exporter functionality in the example. A code owner or user will have to verify the example still works.